Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit author_email if @ not found in authors #1

Closed
wants to merge 1 commit into from
Closed

Omit author_email if @ not found in authors #1

wants to merge 1 commit into from

Conversation

evandrocoan
Copy link

@evandrocoan evandrocoan commented Apr 3, 2020 •
edited
Loading

Following from: PyO3#289 - Stop passing author.email to python

Fixes deploying to PyPI when an email address is not provided.

This master branch also needs to be updated due the requirement:

File: anki/rspy/requirements.txt
1: # fixme: when maturin fixes 32 bit support, switch back to pypi
2: git+https://github.com/dae/maturin#egg=maturin; sys_platform == "linux" and platform_machine != "x86_64"
3: maturin; sys_platform != "linux" or platform_machine == "x86_64"

As of today, the new release 0.80.0 of maturin was released, within this fix, and it will be automatically used on the next installation because there is no restriction on the maturin requirement version.

@dae @evandrocoan
Omit author_email if @ not found in authors
986735a 
Fixes deploying to PyPI when an email address is not provided.

# Conflicts:
#	src/metadata.rs
@evandrocoan evandrocoan mentioned this pull request Apr 3, 2020
Open
@evandrocoan evandrocoan closed this Apr 3, 2020
@evandrocoan evandrocoan deleted the optional_email_master_fix branch April 3, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evandrocoan @dae